Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lumbricus test2 d dfm2msw #200

Open
wants to merge 28 commits into
base: lumbricus
Choose a base branch
from
Open

Lumbricus test2 d dfm2msw #200

wants to merge 28 commits into from

Conversation

rleander
Copy link
Contributor

No description provided.

HendrikKok and others added 27 commits August 22, 2023 10:53
@HendrikKok
update testmodel-f to match driver tests
5d860f6
@HendrikKok
wip
c4a6ebb
@HendrikKok
wip
d37ef68
@HendrikKok
update with test versions
ee9a359
@HendrikKok
Fix for correctly initializing realized arrays in exchange_balance_1d…
c410669 
… class + fix the way the correction flux is computed in dfm_metamod.
@HendrikKok
wip
9297c17
@HendrikKok
wip
7744c16
@HendrikKok
wip
fa6feab
@HendrikKok
wip
d18af8f
First test with dfm 2d
23883e5
adding default toml file for testimod_coupler.toml
cfd86ac
corrected dfm model and adjusted exchanges and imod_coupler.toml
c788870
update of 2d coupling model in progress
d6f7ce9
matched drain locations with slight modifications in dfm 1D nodes
67c43a6
Temporary fix dfm waterlevels to msw
cfd51a2
@HendrikKok
wip
8220652
All log files write modflow time = self time of dfm metamod
9fc2834
added logging of head exchange dfm2d to metaswap
d0c86e8
@HendrikKok
Update to the compute realised 2D function and the exchange_realised_…
e91a0b3 
…ponding_2D for correct exchange between MetaSWAP and DFLOW-2D.
@HendrikKok
Merge branch 'lumbricus_test2D_dfm2msw' of https://github.com/Deltare…
e2f8afd 
…s/imod_coupler into lumbricus_test2D_dfm2msw
no logging of exchanged stages to msw
e1166ea
@HendrikKok
Various changes based on debug sessions. Most important are the chang…
0fad4c9 
…es to the exchange of 2d water levels to MetaSWAP and exchange of realized ponding volumes to MetaSWAP.
@HendrikKok
idem
7e00042
@HendrikKok
Merge branch 'lumbricus_test2D_dfm2msw' of https://github.com/Deltare…
671b8c2 
…s/imod_coupler into lumbricus_test2D_dfm2msw

# Conflicts:
#	imod_coupler/drivers/dfm_metamod/dfm_metamod.py
@HendrikKok
add
27f76f5
pure 2d coupling test
061c858
confusing typo in coupling name: dmf versus dfm referring to dflowfm
ec8ee18
@rleander rleander requested a review from HendrikKok October 30, 2023 15:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

HendrikKok
HendrikKok reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@HendrikKok HendrikKok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the branch were we worked in together right? Should be all the work on making it work?

imod_coupler/drivers/dfm_metamod/dfm_metamod.py.orig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file could be removed i think

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

15 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HendrikKok HendrikKok HendrikKok left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rleander @HendrikKok